Test and fix global package installation #797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Since Travis uses nvm, global installation doesn't require sudo and just works (CC @justinwb). However, trying global installation might catch other problems, and I'm adding an explicit check for GitHub packages in package-lock.json. |
RubenVerborgh
force-pushed
the
fix/no-github-deps
branch
from
0c55d23 to
a204c46
Compare
Contributor
Author
|
Awaiting Mashlib fix in SolidOS/mashlib#18 |
RubenVerborgh
force-pushed
the
fix/no-github-deps
branch
from
a204c46 to
8b934f7
Compare
RubenVerborgh
changed the title
kjetilk
approved these changes
Sep 30, 2018
Member
kjetilk
left a comment
kjetilk
left a comment
There was a problem hiding this comment.
For this, I'm good if Travis is good.
RubenVerborgh
added a commit
that referenced
this pull request
Sep 30, 2018
Test and fix global package installation
Contributor
Author
|
(Accidentally merged into master, but fixed.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure there are no GitHub dependencies (#796) or other things that might break a global installation,