Update oidc-auth-manager to 0.16.1 - #721
Conversation
RubenVerborgh
left a comment
RubenVerborgh
left a comment
There was a problem hiding this comment.
Wow that one messed up the lock file big time 🙂
RubenVerborgh
left a comment
RubenVerborgh
left a comment
There was a problem hiding this comment.
Actually, the Travis failure seems related to the lock file. Can you check? Only latest Node performs deep checks
|
@RubenVerborgh I think there's been a change in how the lockfile gets generated, from (8 or 10?) to 10.5. Like, if I generate a lockfile on 8.9 (that's the one that's running on 8 & 10 but not 10.5), and compare it with a lockfile generated on 10.5, the version syntax that they're using changes. Sooo.. let's see if I generate a lockfile on 10.5 and commit it, if 8 and 10 can run the newer syntax. (If not.. we may need to maintain separate branches for node versions. Or git ignore the package lock) |
|
10 should be fine, and we need to commit the lock indeed 🙂 |
|
Ok whew, that seems to have worked :) |
2 participants
Closes issue #720