Skip to content

Conversation

@dmitrizagidulin
Copy link
Contributor

Closes issue #720

@dmitrizagidulin dmitrizagidulin requested review from RubenVerborgh and removed request for RubenVerborgh July 2, 2018 19:06
Copy link
Contributor

@RubenVerborgh RubenVerborgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that one messed up the lock file big time 🙂

Copy link
Contributor

@RubenVerborgh RubenVerborgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the Travis failure seems related to the lock file. Can you check? Only latest Node performs deep checks

@dmitrizagidulin
Copy link
Contributor Author

@RubenVerborgh I think there's been a change in how the lockfile gets generated, from (8 or 10?) to 10.5. Like, if I generate a lockfile on 8.9 (that's the one that's running on 8 & 10 but not 10.5), and compare it with a lockfile generated on 10.5, the version syntax that they're using changes.

Sooo.. let's see if I generate a lockfile on 10.5 and commit it, if 8 and 10 can run the newer syntax. (If not.. we may need to maintain separate branches for node versions. Or git ignore the package lock)

@RubenVerborgh
Copy link
Contributor

10 should be fine, and we need to commit the lock indeed 🙂

@dmitrizagidulin
Copy link
Contributor Author

Ok whew, that seems to have worked :)

@dmitrizagidulin dmitrizagidulin merged commit 5dad7de into develop Jul 2, 2018
@dmitrizagidulin dmitrizagidulin deleted the fix-init-session-user-auth branch July 2, 2018 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants