Fix delete on containers #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ready for merge. |
Contributor
|
Considering opening an issue on whether ACLs should survive delete. It's unclear. There are use cases on either side of that. On w3.org they do. |
Contributor
Author
|
This is the ACL document that lives within the container. If the container is deleted, it would be impossible to keep the ACL document. |
Contributor
|
Fixing tests, stand by |
For PR #215 - Include RSVP promise lib - Extract test container and resource creation to helper methods - Pass failing tests
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the delete operation did not remove the corresponding meta and acl files. It also failed when trying to delete an empty container.