exclude %encoded / #1690
Closed
exclude %encoded / #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
| _encodePath (pathname) { | ||
| const pathArray = pathname.split(this._exceptSlash()) | ||
| pathArray.forEach((el, i) => { | ||
| if (i % 2 === 0) pathArray[i] = encodeURIComponent(el) |
Contributor
There was a problem hiding this comment.
Might want to normalize path separators to lowercase or uppercase, such that they are mapped to the same filename. (see CommunitySolidServer/CommunitySolidServer#1273)
lib/resource-mapper.js
Outdated
| } | ||
|
|
||
| // encode/decode path except slash/%encodedSlash/double%encodedSlash | ||
| _exceptSlash () { return /(\/|%2f|%2F|%252F|%252f)/g } |
Contributor
There was a problem hiding this comment.
Good find about the %25. Subsequently, we found that we also need to guard against sequences of %25252525 in CommunitySolidServer/CommunitySolidServer#1273.
TallTed
reviewed
Apr 25, 2022
TallTed
reviewed
Apr 25, 2022
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Member
|
I feel that I've been out of this code base for so long that I can't really provide a useful review at this level of detail. But LGTM. |
Member
Author
|
Already merged with #1695 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue #1666
excludes from %encode/%decode
_exceptSlash () { return /(\/|%2f|%2F|%252F|%252f)/g }