reject url with %2F #1678
Closed
reject url with %2F #1678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hmm, is this really what we want to do? What about a URI with an URI-encoded search string? Should it be forbidden in the URI itsdelf but permitted in the search string? |
lib/resource-mapper.js
Outdated
| // URL specified as Express request object | ||
| if (!url.pathname && url.path) { | ||
| const { hostname, path } = url | ||
| if (path.includes('%2F')) throw new Error('Url cannot contain %2F (%encoded /)') |
Contributor
There was a problem hiding this comment.
The above implementation is broken; it only works on 2 out of 3 cases.
Rather than duplicating the code another time, it should be in a single place.
So if you must, do:
// Parses a URL into hostname and pathname
_parseUrl (url) {
let parsed;
// URL specified as string
if (typeof url === 'string') {
parsed = this._parseUURL.parse(url)
}
// URL specified as Express request object
else if (!url.pathname && url.path) {
const { hostname, path } = url
parsed = { hostname, pathname: path.replace(/[?#].*/, '') }
}
// URL specified as object
else {
parsed = url;
}
// <=== do your path replacements here
return parsed
}
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.