Skip to content

Adding fullscreen support for login on iOS #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaxoncreed merged 1 commit into from
May 7, 2019
Merged

Adding fullscreen support for login on iOS #1183

jaxoncreed merged 1 commit into from
May 7, 2019

Conversation

@emiliocortina
Copy link
Contributor

@emiliocortina emiliocortina commented Apr 29, 2019

jaxoncreed
jaxoncreed approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@jaxoncreed jaxoncreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission. Everything looks good to me here. It seems that tests are consistently failing on Travis. Do you see the same when you run things locally? If not, tell me and I'll try to figure out what's going on with Travis.

@emiliocortina
Copy link
Contributor Author

emiliocortina commented May 6, 2019

@jaxoncreed Sorry for taking so long to answer.
It also seems to happen when I run the tests locally. I checked the tests failing in travis and locally and they appear to be the same.
The thing is that I ran the tests against the repository before the changes I made and it still shows the same failing tests.
Screenshot 2019-05-06 at 12 43 54

@jaxoncreed
Copy link
Contributor

jaxoncreed commented May 6, 2019

Oh that's interesting. I'm seeing the same thing. I'll look into that and get back to you.

@jaxoncreed
Copy link
Contributor

jaxoncreed commented May 6, 2019

Okay, @emiliocortina you're code's all good. Looks like one of the sites we have deployed to help us with tests is done.

I've pinged @RubenVerborgh to help us out with that, so once it's back up I'll run the tests.

@emiliocortina
Copy link
Contributor Author

emiliocortina commented May 7, 2019

@jaxoncreed Great! Thanks for your help.

@jaxoncreed jaxoncreed merged commit 730a2ea into nodeSolidServer:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jaxoncreed jaxoncreed jaxoncreed approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emiliocortina @jaxoncreed