Fix server printing stacktrace after logging in, Closes #1000 #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Contributor
RubenVerborgh
left a comment
RubenVerborgh
left a comment
There was a problem hiding this comment.
But don't we need the other headers?
in any case, it's an architectural problem that the headers are sent by the next handler.
Contributor
Author
|
Hmm, yes, you're right. I'll fix that right away! |
rubensworks
force-pushed
the
fix/login-header-error
branch
from
8cf8a92 to
6a0b760
Compare
Contributor
Author
|
I've reverted my last change, as it broke a bunch of things. So actually my initial fix was correct. All necessary headers are present, because |
Contributor
|
Sweet, GitHub now shows force pushes. |
RubenVerborgh
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was because header.js tried to add headers after the response was already sent.