Skip to content

Add server origin by default to the list of trusted origins #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjetilk merged 1 commit into from
Dec 6, 2018
Merged

Add server origin by default to the list of trusted origins #1012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/handlers/allow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ function allow (mode) {
},
suffix: ldp.suffixAcl,
strictOrigin: ldp.strictOrigin,
trustedOrigins: ldp.trustedOrigins
trustedOrigins: [ldp.resourceMapper.resolveUrl(req.hostname)].concat(ldp.trustedOrigins)
})

// Ensure the user has the required permission
Expand Down
20 changes: 19 additions & 1 deletion test/integration/authentication-oidc-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ describe('Authentication API (OIDC)', () => {
})
})

// Our origin isn't trusted by default
// Our origin is trusted by default
describe('with that cookie and our origin', () => {
let response
before(done => {
Expand All @@ -225,6 +225,24 @@ describe('Authentication API (OIDC)', () => {
})
})

it('should return a 200', () => {
expect(response).to.have.property('status', 200)
})
})

// Another origin isn't trusted by default
describe('with that cookie and our origin', () => {
let response
before(done => {
alice.get('/')
.set('Cookie', cookie)
.set('Origin', 'https://some.other.domain.com')
.end((err, res) => {
response = res
done(err)
})
})

it('should return a 403', () => {
expect(response).to.have.property('status', 403)
})
Expand Down