Skip to content

header.test.js : WAC-Allow third test is broken #1285

Description

@bourgeoa

Please describe what you did in reproducible steps

npm run test : on NSSv5.1.1 to NSSv5.1.6
I came to that with PR #1282

How did it work with 4.x series servers?

all test passed on NSSv4.4.2

What happened when you tried the same with the 5.x series server?

  1. Header handler
    WAC-Allow
    a resource that is read/write/append/control for the user, nothing for the public
    "before all" hook:
    Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/volume1/homes/admin/github/awwright/node-solid-server/test/integration/header-test.js)

Any material that will help, logs, error messages, etc.

Here is the faulty test

describeHeaderTest('read/write/append/control for the user, nothing for the public', { resource: '/user-rwac-public-0', headers: { 'WAC-Allow': 'user="read write append control",public=""', 'Access-Control-Expose-Headers': /(^|,\s*)WAC-Allow(,|$)/ } })
I broke the test in two :

  •     'WAC-Allow': 'user="read write append",public=""',
    

here the test fail saying that a WAC-Allow need to be defined for public

  •    'WAC-Allow': 'user="read write append control",public="read"',
    

here the timeout came back.

As it is the test is not pertinent in NSSv5 and should be revisited.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions