Fixed the condition of hasServiceParams#93
Merged
kazuhitoyokoi merged 1 commit intonode-red:masterfrom Feb 27, 2019
Merged
Conversation
`swagger.security` is a definition for the whole API. It is not necessarily set when there is security on individual methods. Therefore it is better to refer to `swagger.securityDefinitions` to see if you need ` hasServiceParams`. `isSecure` judgment also refers to ` swagger.securityDefinitions`. Ref: https://github.com/wcandillon/swagger-js-codegen/blob/master/lib/codegen.js#L41
|
|
Member
|
@7474 Sorry for the delay. 🙏 Thank you for your contribution. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
swagger.securityis a definition for the whole API. It is not necessarily set when there is security on individual methods.Therefore it is better to refer to
swagger.securityDefinitionsto see if you needhasServiceParams.isSecurejudgment also refers toswagger.securityDefinitions.Ref: https://github.com/wcandillon/swagger-js-codegen/blob/master/lib/codegen.js#L41
Checklist
gruntto verify the unit tests pass