TreeList: Fix arrow navigation through filtered TreeList#5431
Open
piotrbogun wants to merge 1 commit intonode-red:masterfrom
Open
TreeList: Fix arrow navigation through filtered TreeList#5431piotrbogun wants to merge 1 commit intonode-red:masterfrom
piotrbogun wants to merge 1 commit intonode-red:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Proposed changes
Resolves #5430
EditableList hides filtered items with
.hide(). Added a css display check when picking the next/previous sibling/child in the TreeList component. With this change, users should be able to navigate through the visible list. Went with this approach for the initial fix as it's a small code change.Could alternatively:
isFilteredflag to the items. Would prefer the above.Before change
tree_list_filter_pre_fix.mp4
After change
tree_list_filter_fix.mp4
Checklist
npm run testto verify the unit tests pass