Skip to content

Add several click-outside-edit-tray behaviors#5385

Open
GogoVega wants to merge 1 commit intonode-red:masterfrom
GogoVega:5247-click-outside-edit-tray
Open

Add several click-outside-edit-tray behaviors#5385
GogoVega wants to merge 1 commit intonode-red:masterfrom
GogoVega:5247-click-outside-edit-tray

Conversation

@GogoVega
Copy link
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Closes #5247.

Foreword: The purpose of that change was to prevent changes from being saved when clicking outside the edit tray and a poor revert is not enough to move forward... In theory, the changes should be discard, but in practice, users have their own preferences.

Revert the click-outside-edit-tray behavior to save changes and close the edit tray.

Also adds to the settings a selection input to allow the user to choose the desired behavior. The options and their behavior are as follows:

  • nothing: do nothing
  • discard: discard changes and close
  • save: save changes and close

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to restore click-outside-edit-tray behaviour

1 participant