Skip to content

Ensure link-call cache is updated when link-in is modified#3695

Merged
knolleary merged 1 commit intomasterfrom
fix-dynamic-link-call
Jun 28, 2022
Merged

Ensure link-call cache is updated when link-in is modified#3695
knolleary merged 1 commit intomasterfrom
fix-dynamic-link-call

Conversation

@Steve-Mcl
Copy link
Contributor

fixes #3694
depends on node-red-node-test-helper@0.3.0

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Discussed here: https://node-red.slack.com/archives/C9RSU6S56/p1655726225125419

Proposed changes

  • Ensures registered nodes are removed from the cache to avoid the "Multiple nodes with name" error
  • Adds a suitable test that loads a flow with 2 link nodes named the same then deploys a name change

NOTE: Depends on node-red-node-test-helper@0.3.0 #54 being merged and published

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

fixes #3694
depends on node-red-node-test-helper@0.3.0
@knolleary
Copy link
Member

I have published test-helper@0.3 - now rerunning the tests on this PR.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 68.244% when pulling 9729c89 on fix-dynamic-link-call into 7171473 on master.

@Steve-Mcl Steve-Mcl requested a review from knolleary June 27, 2022 11:10
@knolleary knolleary merged commit 12b64d1 into master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: Multiple link-in nodes named 'x' found

3 participants