Rename bindings to prevent overflow in Jest#43
Merged
addaleax merged 2 commits intonode-ffi-napi:latestfrom Aug 28, 2020
acdibble:rename-native-export
Merged
Rename bindings to prevent overflow in Jest#43addaleax merged 2 commits intonode-ffi-napi:latestfrom acdibble:rename-native-export
addaleax merged 2 commits intonode-ffi-napi:latestfrom
acdibble:rename-native-export
Conversation
GozaRuu
approved these changes
Aug 28, 2020
Contributor
|
If you do this, can you follow through for all native bindings that follow this pattern, since it’s not just Also, the commit message would ideally point out that this works around a bug in Jest :) |
acdibble
changed the title
Contributor
Author
|
Changed all of the native bindings that followed the same pattern. Updated the PR title to mention Jest, but you can feel free to change it to whatever you feel is best. |
Contributor
|
Thanks, I’ll merge this after the CI runs :) |
Contributor
Author
|
Thanks, I appreciate the responsiveness! |
addaleax
pushed a commit
that referenced
this pull request
Aug 28, 2020
This is a fix for #16, an issue that appears (especially in tests) when `writePointer` turns into an infinitely recursive call and overflows the stack. This PR renames the native binding to already have the underscore to prevent the loop from ever being created. This problem seems to surface mostly when using this library inside of Jest tests. PR-URL: #43 Fixes: #16
Contributor
|
Published in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #16, an issue that appears (especially in tests) when
writePointerturns into an infinitely recursive call and overflows the stack.This PR renames the native binding to already have the underscore to prevent the loop from ever being created.