Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: node-ffi-napi/ref-napi
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: latest
Choose a base ref
...
head repository: node-ffi-napi/ref-napi
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.x
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Aug 28, 2020

  1. Rename bindings to prevent overflow in Jest 

    This is a fix for #16, an issue that appears (especially in tests) when `writePointer` turns into an infinitely recursive call and overflows the stack.

This PR renames the native binding to already have the underscore to prevent the loop from ever being created.

This problem seems to surface mostly when using this library inside of Jest tests.

PR-URL: #43
Fixes: #16
    @acdibble @addaleax
    acdibble authored and addaleax committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    ae9a639 View commit details
    Browse the repository at this point in the history

  2. v2.1.2

    @addaleax
    addaleax committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    07348f5 View commit details
    Browse the repository at this point in the history
Loading