Repository navigation
fix: include AggregateError causes in request failure reason - #1914
Closed
dyk1454683243-sudo wants to merge 1 commit into
Closed
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
When Node's dual-stack connect fails, https/net emits AggregateError with an empty message. Use nested error codes/messages so FetchError no longer ends with an empty "reason:". Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
1 of 2 tasks
Author
|
Withdrawing this PR while I clean up a high-volume open-PR backlog. Sorry for the noise — happy to come back later with a focused change if useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When Node's https/net stack fails both IPv4 and IPv6 connect attempts, it emits an
AggregateErrorwhosemessageis empty. node-fetch only interpolatederror.message, so users saw:Fixes #1841
Changes
error.messageis empty, join nestederror.errorscodes/messages withand.Errorinstances with a non-empty message are unchanged.AggregateError(or empty-message multi-error on Node < 15) on the request error path via a customhttp.Agent.Additional information
Dual-stack connect failures are the usual source of this
AggregateError(see Nodenet.js).