fix: use strict UTF-8 decoding in json() to reject invalid bytes#1879
Open
kshyatisekhar-panda wants to merge 1 commit intonode-fetch:mainfrom
Open
fix: use strict UTF-8 decoding in json() to reject invalid bytes#1879kshyatisekhar-panda wants to merge 1 commit intonode-fetch:mainfrom
kshyatisekhar-panda wants to merge 1 commit intonode-fetch:mainfrom
Conversation
Fixes node-fetch#1853. response.json() was using TextDecoder with default replacementmode, which silently replaced invalid UTF-8 (e.g. lone surrogates) withU+FFFD, allowing invalid JSON to be parsed without error. This changesjson() to use fatal: true, so invalid UTF-8 throws instead of beingsilently corrupted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1853
Summary
response.json()was silently accepting invalid JSON with malformed UTF-8 (e.g. lone surrogate pairs like\ud83d)json()calledthis.text(), which usesTextDecoderwith default replacement mode (fatal: false). This silently replaces invalid UTF-8 bytes with U+FFFD beforeJSON.parse()sees them, so invalid data parses without error.json()now callsconsumeBody()directly and decodes withnew TextDecoder('utf-8', {fatal: true}), so invalid UTF-8 in JSON responses throws aTypeErrorinstead of being silently corrupted.text()remains unchanged — replacement mode is correct for plain text per the Fetch spec.Test plan
TypeError