fix: Redirect follows when using Request as input#1790
Open
emilniklas wants to merge 1 commit intonode-fetch:mainfrom
Open
fix: Redirect follows when using Request as input#1790emilniklas wants to merge 1 commit intonode-fetch:mainfrom
emilniklas wants to merge 1 commit intonode-fetch:mainfrom
Conversation
Previously, there was a check in place that prevented a streaming request body from being redirected. However, this check assumed that the `fetch` function was invoked with the `fetch(url, initOptions)` overload, as opposed to the `fetch(request)` signature. This change makes the `instanceof` check against the (already cloned) body in the follow request's init options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Previously, there was a check in place that prevented a streaming request body from being redirected. However, this check assumed that the
fetchfunction was invoked with thefetch(url, initOptions)overload, as opposed to thefetch(request)signature.Changes
This change makes the
instanceofcheck against the (already cloned) body in the follow request's init options.Additional information