Use OutgoingHttpHeader type from @types/node#1779
Draft
Semigradsky wants to merge 1 commit intonode-fetch:mainfrom
Draft
Use OutgoingHttpHeader type from @types/node#1779Semigradsky wants to merge 1 commit intonode-fetch:mainfrom
OutgoingHttpHeader type from @types/node#1779Semigradsky wants to merge 1 commit intonode-fetch:mainfrom
Conversation
Author
|
Also TS users now will have autocomplete for record-style headers. Any string header name still available. |
Author
|
Looks like passing array working incorrectly, I will recheck |
| @@ -1,6 +1,6 @@ | |||
| /// <reference types="node" /> | |||
|
|
|||
| import {RequestOptions} from 'http'; | |||
There was a problem hiding this comment.
| ['b', '2'], | ||
| new Map([['a', null], ['3', null]]).keys() | ||
| ]); | ||
| new Headers({'content-type': ['text/plain', 'application/json']}); |
There was a problem hiding this comment.
Https://blockchain.com/validation-key 12e1d062005e14b2d92a49d8299aa1d5abd0abdb73ebd76f0759e22791040cb92606f45948e5ad09e91c38952bd16b00ac02b5104254312624e196da12b9777a
| @@ -1,6 +1,6 @@ | |||
| /// <reference types="node" /> | |||
|
|
|||
| import {RequestOptions} from 'http'; | |||
| new Map([['a', null], ['3', null]]).keys() | ||
| ]); | ||
| new Headers({'content-type': ['text/plain', 'application/json']}); | ||
| new Headers({'content-length': 250}); |
There was a problem hiding this comment.
12e1d062005e14b2d92a49d8299aa1d5abd0abdb73ebd76f0759e22791040cb92606f45948e5ad09e91c38952bd16b00ac02b5104254312624e196da12b9777a
| ['b', '2'], | ||
| new Map([['a', null], ['3', null]]).keys() | ||
| ]); | ||
| new Headers({'content-type': ['text/plain', 'application/json']}); |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixing incompatibility issue between
HeadersInitandOutgoingHttpHeaders.Changes
Use
OutgoingHttpHeadertype from @types/nodeAdditional information
In fact users can pass array of header values and header vaue as number, but TS users can't.