docs(README): when patching global context, patch TextDecoder and TextEncoder too#1774
Open
jtomaszewski wants to merge 1 commit intonode-fetch:mainfrom
Open
docs(README): when patching global context, patch TextDecoder and TextEncoder too#1774jtomaszewski wants to merge 1 commit intonode-fetch:mainfrom
jtomaszewski wants to merge 1 commit intonode-fetch:mainfrom
Conversation
Current script contains unnecessary imports. It also doesn't patch `TextDecoder` and `TextEncoder`, which may be referred to using global references while the fetch is happening.
jtomaszewski
changed the title
Collaborator
|
Since this is just readme and no breaking changes, then i would now have suggested another approach. using conditional lazy top level So maybe something like this: // fetch-polyfill.js
globalThis.fetch || await import('node-fetch').then(mod => {
globalThis.fetch = mod.default
globalThis.Blob ??= mod.Blob
globalThis.File ??= mod.File
globalThis.FormData ??= mod.FormData
globalThis.Headers = mod.Headers
globalThis.Request = mod.Request
globalThis.Response = mod.Response
})
globalThis.TextDecoder || import('node:util').then(util => {
globalThis.TextDecoder ??= util.TextDecoder
globalThis.TextEncoder ??= util.TextEncoder
})
// index.js
(globalThis.TextDecoder && globalThis.fetch) || await import('./fetch-polyfill.js') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After following the README on patching the global context, node-fetch fails to me in jest jsdom environment on node v16.16.0 with following error:
That's probably because node-fetch in https://github.com/node-fetch/node-fetch/blob/main/src/body.js#L159 refers to
TextDecoderusing a global reference, which doesn't exist in my environment.Changes
In recommended script in README that patches the global context, add
TextDecoderandTextEncoderto the global context too.I also removed a few unnecessary imports from it that weren't used at all.
Additional information