Response.bodyUsed should be false when there is no body#1686
Open
tkrotoff wants to merge 1 commit intonode-fetch:mainfrom
Open
Response.bodyUsed should be false when there is no body#1686tkrotoff wants to merge 1 commit intonode-fetch:mainfrom
tkrotoff wants to merge 1 commit intonode-fetch:mainfrom
Conversation
tkrotoff
force-pushed
the
fix-bodyUsed
branch
from
a68cfda to
a2ec216
Compare
tkrotoff
commented
Dec 2, 2022
| const res = new Response(toCheck); | ||
| expect(res.bodyUsed).to.equal(false); | ||
|
|
||
| /* eslint-disable-next-line no-await-in-loop */ |
Contributor
Author
There was a problem hiding this comment.
Don't think this lint rule matters in context of unit test
tkrotoff
commented
Dec 2, 2022
| data[INTERNALS].disturbed = true; | ||
|
|
||
| /* c8 ignore next 3 */ | ||
| if (!(body instanceof Stream)) { |
Contributor
Author
There was a problem hiding this comment.
Don't know if disturbed = true should be done after this line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1684