fix: leak fight proposal#41
Open
qfox wants to merge 1 commit into
Open
Conversation
Yeti-or
reviewed
Oct 24, 2018
Yeti-or
left a comment
Yeti-or
left a comment
Collaborator
There was a problem hiding this comment.
Я так и не понял зачем нужен parent
ты можешь написать тест который будет без него падать ?
| let contextKeys; | ||
|
|
||
| sandbox.module = new Module(filename || '<anonymous>', module.parent); | ||
| sandbox.module = new Module(filename, module.parent); |
Collaborator
There was a problem hiding this comment.
если прям нужно оставить parent
давай туда запихнем что-то в духе:
new Module(filename, new Module('', null));
?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37