fix: runner promise bugs that could hang scheduling or crash process#581
Merged
Conversation
Two fixes in the Runner: 1. Replace `new Promise(async ...)` antipattern in runTask with a plain async function. Previously, if beforeRun threw, the promise would never settle, permanently blocking all future executions when noOverlap is enabled. 2. Add .catch() to the TrackedPromise tracking lastExecution. Errors are already reported via onError, but the rejection was never consumed, causing unhandledRejection on Node 22+ (which crashes the process by default).
beforeRun errors were silently swallowed by .catch(() => {}) on the
TrackedPromise. Now they are caught and routed to onError like task errors.
Also protects execute() against onError itself throwing (same class of bug
as the async executor fix), and fixes the jitter setTimeout to always
resolve its promise regardless of errors.
merencia
force-pushed
the
fix/runner-promise-bugs
branch
from
d65e0c1 to
a7b0410
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the Runner:
runTaskusednew Promise(async ...). IfbeforeRunthrew, the promise never settled. WithnoOverlap, this blocked all future executions permanently.The
TrackedPromisetrackinglastExecutionwas never.catch()-ed. On Node 22+ this crashes the process withunhandledRejection.Rewrote
runTaskas a plain async function and added.catch()on the TrackedPromise.