Skip to content

fix: do not fail at max capacity when overwriting key #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marianomerlo wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

fix: do not fail at max capacity when overwriting key #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _src/lib/node_cache.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ module.exports = class NodeCache extends EventEmitter
#
set: ( key, value, ttl )=>
# check if cache is overflowing
if (@options.maxKeys > -1 && @stats.keys >= @options.maxKeys)
if (@options.maxKeys > -1 && @stats.keys >= @options.maxKeys && !@data[ key ])
_err = @_error( "ECACHEFULL" )
throw _err

Expand Down
5 changes: 5 additions & 0 deletions _src/test/mocha_test.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,11 @@ describe "`#{pkg.name}@#{pkg.version}` on `node@#{process.version}`", () ->
true.should.eql setKey3
return

it "overwrite key", () ->
setKey3 = localCacheMaxKeys.set(state.key3, state.value3, 0)
true.should.eql setKey3
return

return

describe "correct and incorrect key types", () ->
Expand Down