Skip to content

Revert "(get) return undefined when key is expired" #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erdii merged 1 commit into from
Nov 17, 2019
Merged

Revert "(get) return undefined when key is expired" #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _src/lib/node_cache.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,8 +510,8 @@ module.exports = class NodeCache extends EventEmitter
# data is invalid if the ttl is too old and is not 0
# console.log data.t < Date.now(), data.t, Date.now()
if data.t isnt 0 and data.t < Date.now()
_retval = false
if @options.deleteOnExpire
_retval = false
@del( key )
@emit( "expired", key, @_unwrap(data) )

Expand Down
4 changes: 2 additions & 2 deletions _src/test/mocha_test.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,11 +1014,11 @@ describe "`#{pkg.name}@#{pkg.version}` on `node@#{process.version}`", () ->
return


it "set a key key with a cache initialized with no automatic delete on expire should be undefined", (done) ->
it "set a key key with a cache initialized with no automatic delete on expire", (done) ->
localCacheNoDelete.set state.key1, state.val
setTimeout(() ->
res = localCacheNoDelete.get state.key1
should(res).eql(undefined)
should(res).eql(state.val)
done()
return
, 500)
Expand Down