Don't allow LMP on PvNodes #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I mentioned this a while back in discord, but nothing seems to have ever come from it. Anyway, to the best of my knowledge most current training data gen is being done at relatively low fixed depths. With this in mind, the change to not allow LMP in PvNodes should result in a fairly significant increase in strength and reliability of the PV.
nodchip
requested changes
Aug 12, 2020
Owner
nodchip
left a comment
nodchip
left a comment
There was a problem hiding this comment.
Thank you for the pull request. Could you check my review comment?
|
|
||
| // Step 13. Pruning at shallow depth (~200 Elo) | ||
| if ( !rootNode | ||
| if ( !PvNode |
Owner
There was a problem hiding this comment.
Could you please add a UCI option to switch the logic? The option name maybe "DontAllowLMPOnPVNodes" or so.
Author
|
What about making it a generic "Training" flag, which could be used for this but also potentially other search changes that may be found to be useful for generating training data down the road? |
Owner
|
It sounds great. I merged your pull request. #82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mentioned this a while back in discord, but nothing seems to have ever come from it. Anyway, to the best of my knowledge most current training data gen is being done at relatively low fixed depths. With this in mind, the change to not allow LMP in PvNodes should result in a fairly significant increase in strength and reliability of the PV.