check nmap path during class init#102
Merged
Merged
Conversation
nmmapper
requested changes
Dec 12, 2024
nmmapper
left a comment
Owner
There was a problem hiding this comment.
The changes you have made we don't see how they are of much concern, you have made changes on almost all files, and yet the commit description shows only check nmap path during class init, the description does not seem to go hand in hand with the changes you have made. The only changes we can accept are in the exception removing the unwanted modules.
Contributor
Author
|
my description is exactly what I did.
I hope I was able to clearly explain what changes I made in the files and why. |
Contributor
Author
|
oh, sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi there. this is my first attempt to contribute in OS
I want to code my own nmap based scanner. Maybe this package will be useful for me
I have tried to make better checking of nmap system path.
And done some code clearing.