Skip to content

check nmap path during class init#102

Merged
nmmapper merged 3 commits into
nmmapper:mainfrom
sashagra:nmapath
Dec 22, 2024
Merged

check nmap path during class init#102
nmmapper merged 3 commits into
nmmapper:mainfrom
sashagra:nmapath

Conversation

@sashagra

Copy link
Copy Markdown
Contributor

hi there. this is my first attempt to contribute in OS
I want to code my own nmap based scanner. Maybe this package will be useful for me

I have tried to make better checking of nmap system path.
And done some code clearing.

@nmmapper nmmapper left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes you have made we don't see how they are of much concern, you have made changes on almost all files, and yet the commit description shows only check nmap path during class init, the description does not seem to go hand in hand with the changes you have made. The only changes we can accept are in the exception removing the unwanted modules.

@sashagra

Copy link
Copy Markdown
Contributor Author

my description is exactly what I did.
I only changed three files

  1. in the exceptions file (nmap3/exceptions.py), I made the exception more clear
  2. in the nmap3/utils.py file, I implemented nmap path checking in the get_nmap_path function. It is at this level that it is more convenient to do it.
  3. in nmap3/nmap3.py I imported the check function and I had to fix all the methods that need this check. I got rid of their repetitive validation logic

I hope I was able to clearly explain what changes I made in the files and why.
If something has left unclear, I could answer your questions and help you figure it out

@sashagra
sashagra requested a review from nmmapper December 12, 2024 19:13
@sashagra

Copy link
Copy Markdown
Contributor Author

oh, sorry
I accidentally clicked something. I don't understand how it works.

@nmmapper
nmmapper merged commit e546893 into nmmapper:main Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants