Skip to content

Commit d256e5c

Browse files
committed
fix(node): stream has a memory leak, use event emitter instead
I think the stream is retaining all of the coins it's fired, until it closes, which never happens. An event emitter is more in line with the intention
1 parent 9082d3d commit d256e5c

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

packages/bitcore-node/src/services/event.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
1+
import { EventEmitter } from "events";
12
import logger from '../logger';
23
import { StorageService } from './storage';
34
import { LoggifyClass } from '../decorators/Loggify';
45
import { EventStorage, IEvent, EventModel } from '../models/events';
5-
import { PassThrough } from 'stream';
66
import { Storage } from './storage';
77
import { Config, ConfigService } from './config';
88

99
@LoggifyClass
1010
export class EventService {
11-
txStream = new PassThrough({ objectMode: true });
12-
blockStream = new PassThrough({ objectMode: true });
13-
addressCoinStream = new PassThrough({ objectMode: true });
11+
txEvent = new EventEmitter();
12+
blockEvent = new EventEmitter();
13+
addressCoinEvent = new EventEmitter();
1414
storageService: StorageService;
1515
configService: ConfigService;
1616
eventModel: EventModel;
@@ -57,7 +57,7 @@ export class EventService {
5757
const txEvent = await txCursor.next();
5858
if (txEvent) {
5959
const tx = <IEvent.TxEvent>txEvent.payload;
60-
this.txStream.write(tx);
60+
this.txEvent.emit('tx', tx);
6161
lastTxUpdate = new Date();
6262
}
6363
}
@@ -73,7 +73,7 @@ export class EventService {
7373
const blockEvent = await blockCursor.next();
7474
if (blockEvent) {
7575
const block = <IEvent.BlockEvent>blockEvent.payload;
76-
this.blockStream.write(block);
76+
this.blockEvent.emit('block', block);
7777
lastBlockUpdate = new Date();
7878
}
7979
}
@@ -89,7 +89,7 @@ export class EventService {
8989
const addressTx = await addressTxCursor.next();
9090
if (addressTx) {
9191
const addressCoin = <IEvent.CoinEvent>addressTx.payload;
92-
this.addressCoinStream.write(addressCoin);
92+
this.addressCoinEvent.emit('coin', addressCoin);
9393
lastAddressTxUpdate = new Date();
9494
}
9595
}

packages/bitcore-node/src/services/socket.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,22 +66,22 @@ export class SocketService {
6666
}
6767

6868
async wireup() {
69-
this.eventService.txStream.on('data', (tx: IEvent.TxEvent) => {
69+
this.eventService.txEvent.on('tx', (tx: IEvent.TxEvent) => {
7070
if (this.io) {
7171
const { chain, network } = tx;
7272
const sanitizedTx = SanitizeWallet(tx);
7373
this.io.sockets.in(`/${chain}/${network}/inv`).emit('tx', sanitizedTx);
7474
}
7575
});
7676

77-
this.eventService.blockStream.on('data', (block: IEvent.BlockEvent) => {
77+
this.eventService.blockEvent.on('block', (block: IEvent.BlockEvent) => {
7878
if (this.io) {
7979
const { chain, network } = block;
8080
this.io.sockets.in(`/${chain}/${network}/inv`).emit('block', block);
8181
}
8282
});
8383

84-
this.eventService.addressCoinStream.on('data', (addressCoin: IEvent.CoinEvent) => {
84+
this.eventService.addressCoinEvent.on('coin', (addressCoin: IEvent.CoinEvent) => {
8585
if (this.io) {
8686
const { coin, address } = addressCoin;
8787
const { chain, network } = coin;

0 commit comments

Comments
 (0)