Skip to content
This repository was archived by the owner on Oct 18, 2021. It is now read-only.

Conversation

@nikkhn
Copy link
Owner

@nikkhn nikkhn commented Sep 28, 2021

  • Pass in package.json info as a parameter for /info endpoint
  • remove local lib/ directory in lieu of using servicelib-node modules

@nikkhn nikkhn requested review from codebuggg, eevans and goodonefrankie and removed request for eevans and goodonefrankie September 28, 2021 13:38
@eevans
Copy link
Collaborator

eevans commented Sep 28, 2021

At some point (when the dust has settled on https://github.com/nikkhn/servicelib-node probably), we should bikeshed module names/namespaces. A term like "utils" doesn't feel super descriptive to begin with (it's right up there with "miscellaneous", or "tools"), but then when you end up with utils/utils or utils/api-utils and it only gets worse. 😄

But, only raising it here after seeing the requiress; That you've done what amounts to a copy-paste from here to servicelib-node without renaming will actually make spelunking through the history later so much more gratifying.

@nikkhn
Copy link
Owner Author

nikkhn commented Sep 28, 2021

I agree it's really confusing and super vague, once this is merged and the corresponding one in servicelib-node is merged too, maybe we can set time to bikeshed the name

@nikkhn nikkhn merged commit 86ce303 into main Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants