Skip to content
This repository was archived by the owner on Oct 18, 2021. It is now read-only.

Commit be4cdbc

Browse files
nikkhneevans
authored andcommitted
fix some wording
1 parent 036aed6 commit be4cdbc

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

STATUS.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,19 @@ The idea behind service-scaffold-node is to separate the existing service-templa
55

66
## To Do:
77
### Remove service-runner
8-
service-runner is an npm package created at the Wikimedia Foundation enabling Node.js services to scale up, by spinning up multiple workers, in an otherwise single-threaded environment, to handle the load. It also handles logging, monitoring, and rate-limiting.
8+
service-runner is an npm package created at the Wikimedia Foundation enabling Node.js services to scale up, by spinning up multiple workers, in an otherwise single-threaded environment. It also handles logging, monitoring, and rate-limiting.
99

10-
After an informal discussion with service-ops, it was determined that service-runner is no longer necessary now that services at WMF will be running in Kubernetes. Kubernetes can now handle scaling up services in reponse to higher loads. The logging and monitoring it current handles will be put into servicelib-node, and the API Gateway is capable of handling the rate limiting.
10+
After an informal discussion with service-ops, it was determined that service-runner is no longer necessary now that services at WMF will be running in Kubernetes. Kubernetes can now handle scaling up services in reponse to higher loads. The logging and monitoring it currently handles will be put into servicelib-node, and the API Gateway is capable of handling the rate limiting.
11+
12+
#### Pros
13+
- Removing a complex, difficult to maintain library. The less code, the better.
14+
- Removing code that is tightly coupled and dependent largely on service-template-node structure
1115

1216
#### Cons
1317
- service-runner can spin up new workers faster than Kubernetes can spin up another instance to support higher loads.
1418
- With more pods come more resource utilization per-pod (e.g. more sidecars, more memory usage, etc. ) We would now be looking at a 1:1 k8s pod to worker ratio, as opposed to N:1 workers to pod ratio.
1519

16-
#### Pros
17-
- Removing a complex, difficult to maintain library. The less code, the better.
18-
- Tightly coupled with and dependent largely on service-template-node structure
19-
2020
### Ideas to explore:
2121
- Use an off-the-shelf worker coordinator
2222
- Create an instance of Envoy to route requests to and from multiple containers
2323

24-
### Middleware

0 commit comments

Comments
 (0)