[PHP 8.0] Add constructor promotion #667
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
Contributor
Author
|
Ready for review |
Contributor
Author
|
I have no idea how to port this part of grammar. At least, I've added test case that is failing to keep https://github.com/php/php-src/pull/5291/files#diff-7eff82c2c5b45db512a9dc49fb990bb8R1092 |
TomasVotruba
commented
Jun 18, 2020
| return $this->pModifiers($node->flags) | ||
| . 'function ' . ($node->byRef ? '&' : '') . $node->name | ||
| . '(' . $this->pCommaSeparated($node->params) . ')' | ||
| . '(' . $this->pMaybeMultiline($node->params) . ')' |
Contributor
Author
There was a problem hiding this comment.
This seems needed to keep param-per-line formatting, to persist the doc block annotation above the param
TomasVotruba
commented
Jun 18, 2020
Contributor
Author
|
This is now ready to review & merge 👍 |
nikic
reviewed
Jun 18, 2020
Owner
|
Thanks! Merged as b58b19e with a change to support formatting-preservation. |
Contributor
Author
|
Any ETA on releasing this? And also PHPStan needs to upgrade to this version before Rector can, as it uses static reflection that prefer it's own classes. |
Owner
|
@TomasVotruba Done! |
Contributor
Author
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on grammar https://github.com/php/php-src/pull/5291/files#diff-7eff82c2c5b45db512a9dc49fb990bb8