fix(cli): Fix broken rootless docker/podman because uid:gid is set - #4778
Open
CaspianChaharom wants to merge 1 commit into
Open
fix(cli): Fix broken rootless docker/podman because uid:gid is set#4778CaspianChaharom wants to merge 1 commit into
CaspianChaharom wants to merge 1 commit into
Conversation
PR nhost#4538 adds `user: <uid>:<gid>` to the docker-compose on the console/constellation services and the hasura-cli wrapper on every Linux host. When running with a rootless daemon, that uid gets remapped to a different host user that cannot access the bind-mounted nhost folder, breaking `nhost up`. Now `docker info` is checked and skips the mapping when the daemon already maps container root to the caller (rootless Docker/Podman, Docker Desktop).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #4538 adds
user: {uid}:{gid}to the docker-compose on the console/constellation services and the hasura-cli wrapper on Linux hosts. When running with a rootless daemon, that uid gets remapped to a different host user that cannot access the bind-mounted nhost folder, breakingnhost up. With the changes here,docker infois checked and skips the mapping when the daemon already maps container root to the caller (rootless Docker/Podman, Docker Desktop).Checklist