Skip to content

Fix build #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix build #210

wants to merge 2 commits into from

Conversation

@kxxt
Copy link

@kxxt kxxt commented Nov 20, 2024

Description

When an incompatible dpdk is installed, the build of libpcap fails. This PR fixes it.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Build it on Arch Linux (with dpdk package installed on system)

Test Configuration:

  • OS version: Arch Linux
  • Python version: 3.12
  • Hardware: not relevant

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

kxxt added 2 commits November 20, 2024 09:50
@kxxt
Stop build upon first error
612c17a 
Stop the build on first error, otherwise when libpcap failed to build we get the following libpcap not found error when linking the engine, which is a little confusing,

/usr/bin/ld: cannot find /tmp/nfstream_build/usr/local/lib/libpcap.a: No such file or directory
collect2: error: ld returned 1 exit status
@kxxt
Disable dpdk when building libpcap
7aaef55 
There are incompatible API changes in DPDK that causes build errors. As we are not using dpdk, explicitly disable it.

 gcc -fvisibility=hidden  -fpic -I.  -include rte_config.h -march=corei7 -mrtm -I/usr/include/libnl3 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -DBUILDING_PCAP -Dpcap_EXPORTS -DHAVE_CONFIG_H  -g -O2    -c ./pcap-dpdk.c
      ./pcap-dpdk.c:202:18: error: ‘struct rte_eth_rxmode’ has no member named ‘split_hdr_size’
        202 |                 .split_hdr_size = 0,
            |                  ^~~~~~~~~~~~~~
      ./pcap-dpdk.c:205:28: error: ‘ETH_MQ_TX_NONE’ undeclared here (not in a function); did you mean ‘RTE_ETH_MQ_TX_NONE’?
        205 |                 .mq_mode = ETH_MQ_TX_NONE,
            |                            ^~~~~~~~~~~~~~
            |                            RTE_ETH_MQ_TX_NONE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kxxt