Add the ability to set tags on a function #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 23, 2018 01:29
…s not present if there are no existing tags
Author
|
@nficano - I've got this and 2 other PRs awaiting response for a bit. If you're interested I'd like to get feedback and merge them before too long. |
nficano
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might need a little more polish, but I added the ability to set/update tags on a function.
The behavior for a new function is straightforward because
create_functionaccepts aTagskeyword.For
update_function_configurationit's a little trickier since that does not acceptTags. The implementation I chose is to only update the existing tags iftagsis set in the config. If so, all existing tags are wiped and the supplied ones are applied. Iftagsis not set in the config then the tags are left alone.Update - on further thought perhaps tags should be applied on an update, but existing ones should be left alone. Thoughts?