Add support for --profile command-line argument
#93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmehnle
force-pushed
the
profile_option
branch
from
6703f55 to
ac4c466
Compare
|
+1 on this. Currently, my workaround is to set |
This allows to choose from what AWS profile to choose credentials from `~/.aws/credentials`.
jmehnle
force-pushed
the
profile_option
branch
from
ac4c466 to
0556916
Compare
javamonkey79
approved these changes
Feb 15, 2018
|
|
||
| def read_cfg(path_to_config_file, profile_name): | ||
| cfg = read(path_to_config_file, loader=yaml.load) | ||
| if profile_name is not None: |
Collaborator
There was a problem hiding this comment.
Instead of:
if profile_name is not None:
Couldn't you just do:
if profile_name:
| return boto3.client( | ||
| client, | ||
| boto3.setup_default_session( | ||
| profile_name=profile_name, |
Collaborator
There was a problem hiding this comment.
If a profile name is set, should secret\access keys still be set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to choose from what AWS profile to choose credentials from
~/.aws/credentials.