Strong cast environment variables to type string #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an environment variable is added to the config, which is just a number, it is decoded from YAML into an int which causes a botocore.exceptions.ParamValidationError
Here is the relevant part of the stack trace:
botocore/validate.py", line 291, in serialize_to_request
raise ParamValidationError(report=report.generate_report())
botocore.exceptions.ParamValidationError: Parameter validation failed:
Invalid type for parameter Environment.Variables.lowThreshold, value: 5, type: <class 'int'>, valid types: <class 'str'>
nficano
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an environment variable is added to the config, which is just a number, it is decoded from YAML into an int which causes a botocore.exceptions.ParamValidationError
Here is the relevant part of the stack trace:
botocore/validate.py", line 291, in serialize_to_request
raise ParamValidationError(report=report.generate_report())
botocore.exceptions.ParamValidationError: Parameter validation failed:
Invalid type for parameter Environment.Variables.lowThreshold, value: 5, type: <class 'int'>, valid types: <class 'str'>
When I changed the relevant code, casting
get_environment_variable_value(value)to typestr, it succeeded in uploading the intended environment variable to AWS without errors.