Skip to content

Tests passing for all Python versions >= 3.6 #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rishabh-bhargava merged 4 commits into from
Apr 7, 2020
Merged

Tests passing for all Python versions >= 3.6 #487

rishabh-bhargava merged 4 commits into from
Apr 7, 2020

Conversation

@rishabh-bhargava
Copy link
Collaborator

@rishabh-bhargava rishabh-bhargava commented Apr 6, 2020 •
edited
Loading

Tests were failing for the latest commit in Python versions 3.5, 3.6 and 3.7. This PR fixes this by:

  • removing testing for Python 3.5 since that runtime is not supported in AWS Lambda
  • updating the Pipfile to unpin Python 3.8 as the only allowed Python version.

@rishabh-bhargava rishabh-bhargava changed the title WIP: Allowing all Python versions in Pipfile Tests passing for all Python versions >= 3.6 Apr 6, 2020
@rishabh-bhargava rishabh-bhargava requested a review from nficano April 6, 2020 08:48
@rishabh-bhargava rishabh-bhargava merged commit d732121 into master Apr 7, 2020
@rishabh-bhargava rishabh-bhargava deleted the allow-python-versions branch April 7, 2020 02:46
@rishabh-bhargava rishabh-bhargava mentioned this pull request Apr 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nficano nficano Awaiting requested review from nficano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rishabh-bhargava