PyYAML loader fix #140
Merged
PyYAML loader fix #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the deprecated pyyaml `load` method with the `full_load` method, which prevents arbitrary code execution. Includes a test suite for the `read` helper method.
The test for the `get_remaining_time_in_millis` method was evaluating the output against a count in seconds, not milliseconds. This corrects the issue to allow the test suite to pass
AWS only supports python2.7+ (technically only 2.7 & 3.6). Additionally PyYAML does not support 2.6 which will cause failures in any case.
Contributor
Author
|
After some changes to the travisCI config and requirements this passes, but perhaps these changes would be better made in a different branch. The changes to the the config are:
|
conor-f
approved these changes
May 2, 2019
Contributor
|
@nficano Please merge this PR! |
luisaverdes
approved these changes
Aug 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This silences the PyYAML
loadwarning on invocation. The warning (and options for silencing/correcting it) is described here: PyYAML yaml.load.Implementing
full_loadstill allows for the full set of yaml syntax.Additionally this adds a new test case for the
readhelper that uses the loader and a minor fix the the other a failing unit test.