Change --use-requirements to --requirements <PATH> (#86) #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** Breaks backwards compatability! **
scotwk
changed the title
Author
|
@nficano - I'm deleting my local environments that I developed this in, so if it needs any changes I'd like to work with you on them while I still have that environment available. Note that it breaks backwards compatibility. (The previous behavior is still available, but the flag name changed) Please let me know if you have any concerns about the change. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86 (@karthich)
** Breaks backwards compatibility! **
I changed the
--use-requirementsflag to--requirements <PATH>to allow a path to be specified.If you are concerned about backwards compatibility the existing flag and behavior can be preserved. I think it might be confusing to have two flags that do roughly the same thing, but I'm not sure how many people are using the current behavior.