Skip to content

fix(files): Fix unneeded space below menu bar on mobile views #7890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

fix(files): Fix unneeded space below menu bar on mobile views #7890

merged 1 commit into from
Nov 5, 2025
+1 −1

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Nov 4, 2025

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
image Screenshot from 2025-11-04 19-48-15

@JuliaKirschenheuter
fix(files): Fix unneeded space below menu bar on mobile views
2e3a178 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Nov 4, 2025
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Nov 4, 2025

@tobiasKaminsky could you please check this version on iOS device please?

@codecov
Copy link

codecov bot commented Nov 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.96%. Comparing base (3e1b521) to head (2e3a178).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7890      +/-   ##
==========================================
- Coverage   47.10%   45.96%   -1.14%     
==========================================
  Files         141      141              
  Lines        3883     3964      +81     
  Branches      733      747      +14     
==========================================
- Hits         1829     1822       -7     
- Misses       1760     1838      +78     
- Partials      294      304      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

max-nextcloud
max-nextcloud approved these changes Nov 5, 2025
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good.

@juliusknorr
Copy link
Member

juliusknorr commented Nov 5, 2025

Merging, as then I can also test iOS once on daily

@juliusknorr juliusknorr merged commit 1e8fb37 into main Nov 5, 2025
64 of 65 checks passed
@juliusknorr juliusknorr deleted the fix/7583-display-errors-on-mobile branch November 5, 2025 15:54
@juliusknorr
Copy link
Member

juliusknorr commented Nov 5, 2025

/backport to stable32

@juliusknorr juliusknorr added bug Something isn't working and removed backport-request labels Nov 5, 2025
@backportbot backportbot bot mentioned this pull request Nov 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@mejo- mejo- Awaiting requested review from mejo- mejo- is a code owner

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

3. to review bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Beta3: display errors on mobile

4 participants

@JuliaKirschenheuter @juliusknorr @max-nextcloud