Carplay ability - #2665
Conversation
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Updated entitlements to include CarPlay communication and modified application groups. Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Removed commented-out French explanations regarding call capabilities and handling. Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
|
Very cool, thanks a lot! We are going to take a closer look in the upcoming week. |
alexm8002
left a comment
alexm8002
left a comment
There was a problem hiding this comment.
Change to Nextcloud default groups
|
Hey @alexm8002 we were checking this PR and noticed that required changes in the project are not committed. Can you check on your end and make sure everything is in place for a complete review? |
SystemKeeper
left a comment
SystemKeeper
left a comment
There was a problem hiding this comment.
Missing project files
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
|
I added the project files. Sorry, my mistake... I thought I had uploaded all. |
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
SystemKeeper
left a comment
SystemKeeper
left a comment
There was a problem hiding this comment.
Hey, thanks for updating the PR :) I just checked more of the "structural" side of things and commented some.
Because of the changes I am wondering, did you use anything besides Xcode? Is the PR in the current form runnable for you?
Removed duplicate SPDX license comment and added copyright notice. Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Remove unnecessary comments about callRecord parameter. Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Removed unnecessary comments and header information. Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Removed unnecessary comments and header from CarPlayConversationProvider.swift Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
…atad/UserInterfaceState.xcuserstate Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
…atad/IDEFindNavigatorScopes.plist Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
…ad/xcschemes/xcschememanagement.plist Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
…atad/xcdebugger/Breakpoints_v2.xcbkptlist Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
Signed-off-by: alexm8002 <a.m.a.martinez@icloud.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Hey, thanks a lot for our work! We are very close to the next major release (next week). We will check your PR, but most likely not merge it before the final. |
2 participants
@SystemKeeper,
This pull request adds Carplay functionnality to Nextcloud Talk-ios:
Notifications have not been tested at the moment.
A Carplay enabled signing profile is necessary to build this branch.