Repository navigation
fix: Signaling timestamp type - #19947
Open
SystemKeeper wants to merge 2 commits into
Open
SystemKeeper wants to merge 2 commits into
SystemKeeper wants to merge 2 commits into
Conversation
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
SystemKeeper
added
bug
feature: api 🛠️
SystemKeeper
changed the title
Contributor
Author
|
Not used by signaling server or sip bridge itself. |
SystemKeeper
marked this pull request as ready for review
October 22, 2026 07:39
Member
Then we could remove it? |
Contributor
Author
|
The Lines 1512 to 1513 in 89105e7 and then later used from the room object. It seems active-since is never used by web 🤔 Not sure if it's an oversight or really intended, but in theory that one could go.
|
Member
That is for indicating a call? But maybe we only do that by chat message nowadays |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ API Checklist
Since on API level (RoomFormatter) we always return an int (this means also
0instead ofnull), it should be the same here.🏁 Checklist
docs/has been updated or is not required