Skip to content

fix: Mark session as inactive again after rejoin - #19872

Open
SystemKeeper wants to merge 1 commit into
mainfrom
fix/noid/background-inactive-session
Open

SystemKeeper wants to merge 1 commit into
mainfrom
fix/noid/background-inactive-session

Conversation

@SystemKeeper

Copy link
Copy Markdown
Contributor

☑️ Resolves

Noticed today I did not receive messages of a conversation that was in an inactive tab. This happened after the laptop returned from standby.

  1. Have a tab in the background, notice that it correctly sends the inactive state
  2. Make the signaling connection rejoin (e.g. while having a laptop in standby for a while)
  3. The tab then rejoins and gets a new session on the server, that session is marked as active by default
  4. Since we still believe that our current state is inactive, we never send the inactive state again. Therefore our session stays active forever and we never get notifications again.

A known limitation seems to be changing conversations in the background (e.g. with breakout rooms). That sounds like an acceptable limitation to me.

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Assisted-by: ClaudeCode:claude-opus-5.5
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper added this to the ☃️ Next Major (36) milestone Oct 16, 2026
@SystemKeeper
SystemKeeper requested a review from Antreesy October 16, 2026 17:32
@SystemKeeper SystemKeeper self-assigned this Oct 16, 2026
@SystemKeeper SystemKeeper added bug feature: chat 💬 Chat and system messages feature: signaling 📶 Internal and external signaling backends feature: frontend 🖌️ "Web UI" client labels Oct 16, 2026
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client feature: signaling 📶 Internal and external signaling backends

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants