Repository navigation
Conversation
- A transcript block that is not rendered has no client rects, so no lines were found and the last line was read from an empty list. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
… layout - Lines are kept between updates, so the last known chunk can lose its client rects before the lines are reset, and its last rect was read from an empty list. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- Stored lines can point to chunks that lost their client rects, so the boundaries are empty until the lines are detected again. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- When the transcript is hidden the line has no boundaries, so scrolling is skipped and retried on the next update. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
fix/19733/transcript-no-client-rects
branch
from
October 16, 2026 14:49
1f93021 to
0fc55c0
Compare
Antreesy
added this pull request to stack #19871
October 16, 2026 15:08
3 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Setup for all scenarios (during the call in the console):
Scenario 1: skip line detection for chunks without layout
say('hello'); setTimeout(() => { hide(); say('more') }, 3000)Scenario 2: stop line detection when the last known chunk has no layout
say('hello'); say('more'); setTimeout(() => { hide(); say('other speaker', 'b') }, 3000)Scenario 3: return no line boundaries when lines have no layout
say('hello'); say('more'); setTimeout(() => { hide(); say('other speaker', 'b') }, 3000)Scenario 4: skip scrolling to a line without layout
say('hello'); say('more'); setTimeout(() => { hide(); say('other speaker', 'b') }, 3000)hide(false)AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist