Repository navigation
fix(reaction): Mark one-to-one unread on reactions - #19867
Open
nickvergessen wants to merge 3 commits into
Open
nickvergessen wants to merge 3 commits into
nickvergessen wants to merge 3 commits into
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
papercut
feature: api 🛠️
Antreesy
reviewed
Oct 16, 2026
Member
Author
|
@Antreesy not sure I like it, as it cuts off easily, depending on the name or language. Or should we skip the name completely because it is the same name as in the title?
|
Member
Author
|
/backport to stable35 |
Contributor
|
I was about to suggest 'No name', as we already do for messages in 1-1 |
Antreesy
reviewed
Oct 19, 2026
| if (lastMessage.value.systemMessage === MESSAGE.SYSTEM_TYPE.REACTION) { | ||
| const reaction = lastMessage.value.actorId === item.value.actorId && lastMessage.value.actorType === item.value.actorType | ||
| ? t('spreed', 'You reacted with {reaction}', { reaction: lastMessage.value.message }, { escape: false, sanitize: false }) | ||
| : t('spreed', 'Reacted with {reaction}', { |
Contributor
There was a problem hiding this comment.
// TRANSLATORS A 2nd person in private conversation has reacted with emoji '{reaction}'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: ClaudeCode:claude-opus-5-5
Fixes
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist
🏁 Checklist
docs/has been updated or is not required