Repository navigation
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: lazerg <lazerg2@gmail.com>
lazerg
requested review from
ChristophWurst,
SebastianKrupinski,
hamza221 and
tcitworld
as code owners
November 9, 2026 15:41
SebastianKrupinski
force-pushed
the
fix/issue-66486-import-uid-less
branch
from
November 10, 2026 19:56
702b669 to
d352924
Compare
Contributor
|
Hi @lazerg Thank you for the PR. But this is not the correct solution for the issue. |
Contributor
Author
|
Thanks for looking. Which approach do you prefer: generating a UID for these components on import, or something else? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The import
TextImporterstores components that have a UID as a list of instances, but a component without a UID was stored as a single bare instance.ImportServicealways reads$instances[0]and passes its offsets toextract(), so the first card or event without a UID threw a TypeError and aborted the whole import. This wraps the UID-less entry in a list in the CardDAV and CalDAV text importers and in the xCal importer, which had the same pattern. Such objects now reach the existing "without a UID" handling inimportProcess()like any other object, so they are reported per item instead of aborting the import. They are still not imported, since that would need a generated UID and I left that call to you. I added tests for vcf, ical and xcal input.Checklist
3. to review, feature component)stable32)AI (if applicable)