chore: Move StorageObjectStore into test support without changing coverage#59280
Open
joshtrichards wants to merge 18 commits intomasterfrom
Open
chore: Move StorageObjectStore into test support without changing coverage#59280joshtrichards wants to merge 18 commits intomasterfrom
StorageObjectStore into test support without changing coverage#59280joshtrichards wants to merge 18 commits intomasterfrom
Conversation
Replaces class StorageObjectStore that currently exits in production code but is purely a test support class and renames it to make use-case somewhat clearer. Signed-off-by: Josh <josh.t.richards@gmail.com>
Replaced with test-only class StorageBackedObjectStore Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…tStore Signed-off-by: Josh <josh.t.richards@gmail.com>
…ObjectStore Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…Store Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
This PR relocates
StorageObjectStorefrom production object store code into test support code.I've been confused by the presence of this class on numerous occasions. It took until today for me to look closer and realize it's 100% a test support class.
Why:
StorageObjectStoreis used as a storage-backed test adapter, but currently lives next to production object store implementations. That makes it easy to confuse with a supported production backend.Changes:
StorageObjectStoreinto/tests/ etc and out ofOC\namespaceStorageBackedObjectStorefor added clarityNotes;
ObjectStoreStoragebehavior is still coveredPrimaryObjectStoreConfigcoverage is preserved, with the same kind of configured class-string usage as beforeTODO
Checklist
3. to review, feature component)stable32)AI (if applicable)