refactor(files_external): migrate to script-setup and Vue 3#57237
Merged
refactor(files_external): migrate to script-setup and Vue 3#57237
Conversation
susnux
added
technical debt
♻️ refactor
susnux
requested review from
come-nc,
nfebe,
provokateurin and
sorbaugh
and removed request for
a team
32 tasks
susnux
force-pushed
the
refactor/files-external-vue3-ts
branch
from
11227a3 to
25a0d78
Compare
Merged
Merged
susnux
force-pushed
the
refactor/files-external-vue3-ts
branch
5 times, most recently
from
d26c076 to
d13f2fe
Compare
36 tasks
susnux
force-pushed
the
refactor/files-external-vue3-ts
branch
from
d13f2fe to
f7e6c72
Compare
Contributor
Author
|
/compile rebase |
…nd Vue 3 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…educe duplicated code between admin and user settings Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Prevent HTTP 500 errors where a 400 would be the correct response Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Template parameters are migrated to initial state, common state between admin and user settings is shared in the CommonSettingsTrait. The template is cleaned and replaced with only a stub for the Vue mount. Code only used for the frontend of the settings is moved from the MountConfig to the CommonSettingsTrait (the missing dependency messages). On the frontend a wrapper view is created that currently holds the global credentials settings and the external storages settings. - The global credentials sections is now a stand-alone sections - fully implemented. - The external storages section holds the table + user config + warnings on missing dependencies The legacy UI is temporarly renamed but will be removed in a following commit. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
refactor/files-external-vue3-ts
branch
from
f7e6c72 to
31957ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate to script-setup where possible, add some missing doc strings and use Vue 3 for the few components.
Checklist
3. to review, feature component)stable32)