Skip to content

fix: Search and Activity dialog not showing - #10433

Merged
mgallien merged 1 commit into
masterfrom
bugfix/dialogs
Jul 23, 2026
Merged

mgallien merged 1 commit into
masterfrom
bugfix/dialogs

Conversation

@Rello

@Rello Rello commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Assisted-by: GPT-5.6

Search and Activity dialog not showing

Assisted-by: GPT-5.6
Signed-off-by: Rello <github@scherello.de>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d7601b65c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/gui/settingsdialog.cpp

@claucambra claucambra left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how the palette/styling changes are necessary to fix the issue

@Rello

Rello commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

I don't see how the palette/styling changes are necessary to fix the issue

yes. correct. was put in also. second PR would have been more correct. the current settings dialog is broken

@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10433.zip

Digest: sha256:54a85df4376668524e6038eef7be18054ca3e83c39370e40c1702ba244849646

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
mgallien merged commit 8b999e0 into master Jul 23, 2026
21 checks passed
@mgallien
mgallien deleted the bugfix/dialogs branch July 23, 2026 08:47
@mgallien

Copy link
Copy Markdown
Collaborator

/backport to stable-34.0 please

@backportbot

backportbot Bot commented Jul 23, 2026

Copy link
Copy Markdown

The backport to stable-34.0 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-34.0
git pull origin stable-34.0

# Create the new backport branch
git checkout -b backport/10433/stable-34.0

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2d7601b6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/10433/stable-34.0

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/10433/stable-34.0."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
43 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

@nilsding nilsding added this to the 34.0.0 milestone Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants