Skip to content

fix: Use OCP\IAppConfig instead of OCP\IConfig to prevent config error #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
R0Wi merged 1 commit into from
Nov 25, 2025
Merged

fix: Use OCP\IAppConfig instead of OCP\IConfig to prevent config error #713

R0Wi merged 1 commit into from
Nov 25, 2025

Conversation

@R0Wi
Copy link
Member

@R0Wi R0Wi commented Nov 22, 2025

When using the CLI to register a daemon

php occ app_api:daemon:register --set-default --harp --harp_frp_address "appapi-harp:8782" --harp_shared_key "<pass>" "harp_proxy_docker" "HaRP Proxy (Docker)" "docker-install" "http" "appapi-harp:8780" "http://my-nc-instance.com"

I'm getting:

In AppConfig.php line 873:
                                                           
  conflict between new type (mixed) and old type (string)

I think the problem only occurs when I already had a previous daemon installed which I uninstalled first.

image

This PR does not only resolve the problem but also removes the use of a deprecated NC function.

kyteinsky
kyteinsky approved these changes Nov 25, 2025
View reviewed changes
Copy link
Collaborator

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
It seems this one instance was not converted to IAppConfig which resulted in the conflict.

@R0Wi R0Wi merged commit b2cc36a into main Nov 25, 2025
34 checks passed
@R0Wi R0Wi deleted the fix/app-config branch November 25, 2025 17:45
@oleksandr-nc
Copy link
Contributor

oleksandr-nc commented Dec 2, 2025

We need a fix for this fix. default_daemon_config treated everywhere as lazy setting.

Will open a PR for this.

@oleksandr-nc oleksandr-nc mentioned this pull request Dec 2, 2025
Merged
@oleksandr-nc
Copy link
Contributor

oleksandr-nc commented Dec 2, 2025

/backport to stable32

@backportbot backportbot bot mentioned this pull request Dec 2, 2025
Merged
@oleksandr-nc
Copy link
Contributor

oleksandr-nc commented Dec 2, 2025

It's better to do it with two backports so as not to lose the git history

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyteinsky kyteinsky kyteinsky approved these changes

Assignees

No one assigned

Labels

feedback-requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@R0Wi @oleksandr-nc @kyteinsky